prov/shm: make smr buffer pool allocations cache line aligned#11432
Open
snadampal wants to merge 1 commit intoofiwg:mainfrom
Open
prov/shm: make smr buffer pool allocations cache line aligned#11432snadampal wants to merge 1 commit intoofiwg:mainfrom
snadampal wants to merge 1 commit intoofiwg:mainfrom
Conversation
Fixed the smr buffer pool alignment to match cache line size on x86 and aarch64 cpus. This has improved the p99 latencies and also throughput for nccl collective tests. Signed-off-by: Sunita Nadampalli <[email protected]>
Contributor
|
@snadampal Can you share some benchmarks and numbers your ran? |
aingerson
reviewed
Sep 23, 2025
| /* | ||
| * Set alignment to aarch64 and x86 cache line size. | ||
| */ | ||
| #define SHM_SMR_BUFPOOL_ALIGNMENT (64) |
Contributor
Author
There was a problem hiding this comment.
@aingerson thanks for the prompt review. I'm running some internal benchmarks, will try to collect data that I can share here.
remove shm prefix
:) I started with SMR_BUFPOOL_ALIGNMENT name and in the last minute I've added SHM prefix to make it provider specific. sure, I will remove the prefix it to match the other definitions related to smr.
Contributor
There was a problem hiding this comment.
@snadampal SMR is the prefix for the shm provider. It is used instead of SHM to avoid any potential conflict with UNIX/Linux IPC "shm".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the smr buffer pool alignment to match cache line size on x86 and aarch64 cpus. This has improved the p99 latencies and also throughput for nccl collective tests.